GenPatch: FakePlayers in lobby

[styler_ro]

uninstall it and all work perfect.

[thesavagepony]

Gen, can I use this patch with regualr ghost?

[Gen]

uninstall it and all work perfect.

your patching of multiple patches wasn't good enough. The patches might not be compatible with each other. In your case, one'd collide and circumvent the FP patch.

Gen, can I use this patch with regualr ghost?
I haven't tested it on ghost++. FP patch Version 1.0 works fine on GhostOne. Since GhostOne based off ghost++, so it should work on ghost++.
Version 1.1 is in the last testing. I'll post version 1.1 of this patch by tomorrow. So, come back tomorrow.

[Gen]

Technically, look at the patch, TCP socket problems (though they're rare) are generated by auto inserting fakeplayers in event player left void (when a player left). Func CreateInitialFakePlayers() is recalled, in it, a while loop to create one-by-one FP does create 2-3-4 of them(2-3-4 fps at once as C++ is fast), the slot info is sent 2-3-4 times to update it. Sending slot info too fastly reproduces the problem.

I tried removed calling CreateInitialFakePlayers() and relied on  CreateFakePlayer() which means to creat A FP instead in that event with the same condition (as below) but it even generated more TCP socket errors (talking about frequency).

Code:

if (GetNumHumanPlayers( ) < 4 && GetSlotsOpen() > 2)
CreateFakePlayer( );

I put the whole // auto insert part in if (!show) as it means for lobby. show ==true, means a player left in game not in lobby. but Ghost crashed after a while of running. The above part is also tested in if(!show) but the problem has not been resolved.

The player left event is messing it up and making the //auto insert go awry. I don't admin TCP socket errors are caused by this patch. AS there're dozen of reasons players get this error, especially if you broadcast to Garena. But I esteem very few TCP socket errors (1%) in my hosting of 4 games simultaneously.

Now, I think of putting //auto insert part in event player join, as it's surely where players are just about in lobby, no  in-game leaving would mess it up. There must be a better place to put the part but I haven't found it yet.
Whenever I find out or think there's a good solution, there could be a better or even best solution. The helps from good coders are welcome.
 

[Gen]

fakeplayer1.1_fix4version1.0.patch & fkplayers1.1 Released.

If you never install fakeplayers.patch, give fkplayers1.1.patch a shot.
If you have installed, please use the fix to update.

PLS get back to this thread and give some feedbacks after your patching, testing, hosting & playing.

[Gen]

This is for 1.1b to prevent the outnumber of fps in lobby and better do a clean-up. Tested & worked well.

Code:

//auto delete fake player(s)
if (m_FPEnable){
if ( ( GetSlotsOpen( ) < 2 || GetNumHumanPlayers( ) > 3 ) && !m_FakePlayers.empty() )
DeleteAFakePlayer( ); // we delete a fp when the lobby has < 2 open slots or > 3 human players
else if ( GetSlotsOpen( ) > 3 && GetNumHumanPlayers( ) < 4 && m_FakePlayers.size() < 3 )
CreateFakePlayer( ); // we only allow a maximum of 3 fps to be created, no fp added once there're >=4 human ppls in lobby, the number of them then declines gradually
}

fix for !df. modify this in DeleteAFakePlayer() function

Code:

@@ -8477,11 +8549,11 @@
  m_Slots[i] = CGameSlot( 0, 255, SLOTSTATUS_OPEN, 0, m_Slots[i].GetTeam( ), m_Slots[i].GetColour( ), m_Slots[i].GetRace( ) );
  SendAll( m_Protocol->SEND_W3GS_PLAYERLEAVE_OTHERS( *j, PLAYERLEAVE_LOBBY ) );
  m_FakePlayers.erase(j);
- break;
+ SendAllSlotInfo( );
+ return;
  }
  }
  }
- SendAllSlotInfo( );
 }
 
 void CBaseGame :: DeleteFakePlayer( )

[thesavagepony]

is this working well?

[Gen]

working perfectly.

[doughnet]

I never come to understand what was good about having a fakeplayer in the lobby.  Anyone able to provide input?

[uakf.b]

I think it's to make players think that there are more players in the game than there actually are. If this is correct, then it's really stupid and no one should use it.

[Gen]

well it's up to you. Apart from dota games ( i never host) it's quite often 1-2 ppls join lobby and leave so early (all the time) b'cuz they can't afford to wait until all slots filled up. An outcome of a gameful of ppls is just amazing.

[uakf.b]

That doesn't mean you should trick them into staying.

[King_Crusher]

For most bots and games, if everyone who joined stayed for at least 2 minutes, then games would get started A LOT faster. The problem isn't always that people don't join, the problem is that they join and leave almost instantly when they see the lobby is nearly empty - and therefore the lobby stays nearly empty.

[uakf.b]

That doesn't mean you should trick them into staying.

Now you're just wasting their time. They think the game is full, but nope, it's actually empty so they have to wait for another thirty minutes until the fake players are gone; while they could have finished a game of DotA in the meantime.

[styler_ro]

btw, who use this? this patch kick users with tcp error.